Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output with descriptor: addr(TAPROOT) #36

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

DmytroShalaiev
Copy link

@DmytroShalaiev DmytroShalaiev commented Jan 4, 2024

#35 realization

Also:

  1. Update package dependencies

TODO: tests.

@landabaso
Copy link
Member

Thanks for the PR, @DmytroShalaiev! I appreciate your contribution. I'm quite busy at the moment, but I should be able to review it in detail next week.

@DmytroShalaiev
Copy link
Author

Thanks, I will be glad for your thoughts.

@DmytroShalaiev DmytroShalaiev marked this pull request as ready for review January 15, 2024 16:56
@siwakawa
Copy link

Hi @landabaso , just checking in to see if you had a chance to review the Taproot integration PR. Let me know if there’s anything I can assist with. Thanks!

@landabaso
Copy link
Member

I want to make sure this is done right. I'm interested in not just adding a Taproot address but implementing Taproot with Miniscript, which is not trivial. This is something I'll need in the mid-term, but I'm short on time at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants