Dependency update #50
Conversation
src/data.rs
Outdated
| reader.read_to_end(&mut bytes).await.unwrap(); | ||
| let custom_asset = serde_json::from_slice::<A>(&bytes).unwrap(); |
There was a problem hiding this comment.
I don't think unwrap is okay here, we don't want to panic and crash the application if there is a malformed JSON.
Probably you need to map the error to make Self::Error
src/info.rs
Outdated
| 1., | ||
| 0., | ||
| ))) | ||
| .unwrap(); |
There was a problem hiding this comment.
This unwrap causes the application to panic the application upon SVG exporting or when drag and dropping a map to the application (maybe on more events).
thread 'main' panicked at src/info.rs:150:14:
called `Result::unwrap()` on an `Err` value: 0.99783385
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Encountered a panic in system `shu::info::pop_infobox`!
Encountered a panic in system `bevy_app::main_schedule::Main::run_main`!
(I am testing on --release.)
| roarsvg::fill( | ||
| roarsvg::Color::new_rgb(fill_color[0], fill_color[1], fill_color[2]), | ||
| fill.color.a(), | ||
| fill.color.hue(), |
There was a problem hiding this comment.
Why is the opacity here (and below) set to the hue?
There was a problem hiding this comment.
The issues about crashing the application on some events remain. By the way, for the CI to pass, both cargo fmt and cargo test has to be run without issues (more of this in the docs' contribution section).
| @@ -147,6 +147,6 @@ fn pop_infobox( | |||
| 1., | |||
| 0., | |||
| ))) | |||
| .unwrap(); | |||
| .map_err(|e|format!("Error:{}",e.get_represented_type_info().unwrap().type_path())).unwrap(); | |||
There was a problem hiding this comment.
This unwrap is not acceptable either.
Removing the unwrap (leaving the error unhandled) makes drag and dropping work but we should investigate why exactly this error arises.
Co-authored-by: Jorge Carrasco <[email protected]>
|
Hi, @Guelakais, are you interested in continuing this? Otherwise, I might have time in the coming weeks and I'd like to work in some features (before or after bevy version is updated here). |
|
Closing in favor of #51 |
The only dependency I couldn't upgrade straight away was
colorgrad. The rest is running now.