Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose OverflowAxis::Hidden as Overflow functions #17528

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

expose OverflowAxis::Hidden as Overflow functions #17528

wants to merge 2 commits into from

Conversation

LucDrenth
Copy link
Contributor

Objective

expose OverflowAxis::Hidden as functions of Overflow, just as it is done for OverflowAxis::Hidden and OverflowAxis::Scroll.

@mnmaita mnmaita added C-Feature A new feature, making something new possible A-UI Graphical user interfaces, styles, layouts, and widgets X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 25, 2025
ickshonpe
ickshonpe suggested changes Jan 25, 2025
View reviewed changes
Copy link
Contributor

@ickshonpe ickshonpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc comments need a little more just explaining why hidden is different to clipped.
Otherwise looks good.

crates/bevy_ui/src/ui_node.rs Outdated Show resolved Hide resolved
@BenjaminBrienen BenjaminBrienen added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnmaita mnmaita mnmaita approved these changes

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

@ickshonpe ickshonpe ickshonpe approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LucDrenth @ickshonpe @BenjaminBrienen @mnmaita