Downgrade clippy::allow_attributes and clippy::allow_attributes_without_reason to warn
#17320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thout_reason` to `warn`
LikeLakers2
added a commit
to LikeLakers2/bevy
that referenced
this pull request
Jan 12, 2025
LikeLakers2
added a commit
to LikeLakers2/bevy
that referenced
this pull request
Jan 12, 2025
alice-i-cecile
approved these changes
Jan 12, 2025
alice-i-cecile
added
D-Trivial
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
I realized that setting these to
denymay have been a little aggressive - especially since we upgrade warnings to denies in CI.Solution
Downgrades these lints to
warn, so that compiles can work locally. CI will still treat these as denies.