Renamed members of ParamWarnPolicy to reflect new behaviour.
#17311
+18
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `Once` renamed to `Warn`. - `param_warn_once()` renamed to `warn_param_missing()`. - `never_param_warn()` renamed to `ignore_param_missing`.
BenjaminBrienen
approved these changes
Jan 11, 2025
BenjaminBrienen
added
D-Trivial
alice-i-cecile
approved these changes
Jan 12, 2025
alice-i-cecile
added
the
M-Needs-Migration-Guide
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
|
I'll merge this once there's a migration guide :) |
|
Added :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oncerenamed toWarn.param_warn_once()renamed towarn_param_missing().never_param_warn()renamed toignore_param_missing().Also includes changes to the documentation of the above methods.
Fixes #17262.
Migration Guide
ParamWarnPolicy::Oncehas been renamed toParamWarnPolicy::Warn.ParamWarnPolicy::param_warn_oncehas been renamed toParamWarnPolicy::warn_param_missing.ParamWarnPolicy::never_param_warnhas been renamed toParamWarnPolicy::ignore_param_missing.