Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use one BevyManifest instance per crate in proc macros #17310

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Use one BevyManifest instance per crate in proc macros #17310

wants to merge 1 commit into from
+36 −23

Conversation

mdickopp
Copy link
Contributor

Objective

Fixes #17004

Solution

Store BevyManifest instances in a hash map keyed on the value of the CARGO_MANIFEST_DIR environment variable. This causes one BevyManifest instance per crate to be created.

Testing

@mdickopp mdickopp marked this pull request as draft January 11, 2025 15:33
@mdickopp mdickopp mentioned this pull request Jan 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rust-analyzer autocomplete is broken for some ECS types
1 participant
@mdickopp