Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Compiler Errors for bevy_tasks #17296

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Improve Compiler Errors for bevy_tasks #17296

merged 1 commit into from
Jan 11, 2025

Conversation

bushrat011899
Copy link
Contributor

Objective

Solution

  • Added a dummy LocalExecutor (un)implementation to suppress irrelevant errors.
  • Added explicit compiler_error! when not selecting either the async_executor or edge_executor features

Testing

  • CI

@bushrat011899 bushrat011899 changed the title Improve Compiler Erros for bevy_tasks Improve Compiler Errors for bevy_tasks Jan 10, 2025
@bushrat011899 bushrat011899 added C-Bug An unexpected or incorrect behavior A-Tasks Tools for parallel and async work P-Compile-Failure A failure to compile Bevy apps D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 10, 2025
@BenjaminBrienen BenjaminBrienen added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 11, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 11, 2025
Merged via the queue into bevyengine:main with commit 14aeaa3 Jan 11, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Tasks Tools for parallel and async work C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples P-Compile-Failure A failure to compile Bevy apps S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to compile certain bevy crates directly, unless an executor is defined separately for bevy_tasks
3 participants
@bushrat011899 @alice-i-cecile @BenjaminBrienen