Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bevy_text: Apply #![deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)] #17285

Merged
merged 1 commit into from
Jan 10, 2025
Merged

bevy_text: Apply #![deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)] #17285

merged 1 commit into from
Jan 10, 2025

Conversation

LikeLakers2
Copy link
Contributor

Objective

Solution

Set the clippy::allow_attributes and clippy::allow_attributes_without_reason lints to deny, and bring bevy_text in line with the new restrictions.

Testing

cargo clippy --tests --all-features --package bevy_text was run, and no errors were encountered.

@LikeLakers2 LikeLakers2 mentioned this pull request Jan 10, 2025
Closed
2 tasks
@BenjaminBrienen BenjaminBrienen added D-Trivial Nice and easy! A great choice to get started with Bevy C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Text Rendering and layout for characters labels Jan 10, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 10, 2025
Merged via the queue into bevyengine:main with commit fec382d Jan 10, 2025
33 checks passed
@LikeLakers2 LikeLakers2 deleted the lint/deny_allow_and_without_reason/bevy_text branch January 10, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

Assignees
No one assigned
Labels
A-Text Rendering and layout for characters C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LikeLakers2 @BenjaminBrienen @alice-i-cecile