custom_ui_material border fix
#17282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttom but in `custom_ui_material` the selectors switch them so left is right and top is bottom. Reversed the conditions so the correct edge values are selected.
ickshonpe
added
C-Bug
rparrett
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Confirmed issue and fix by modifying the ui_material example.
border: UiRect {
top: Val::Px(20.),
left: Val::Px(20.),
bottom: Val::Px(10.),
right: Val::Px(10.),
},Since you seem to understand this shader code, maybe you could sprinkle a few comments and/or expand the mysterious one letter variable names while you're in there?
alice-i-cecile
approved these changes
Jan 11, 2025
alice-i-cecile
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The order of the border edges in
UiVertexOutputis left, right, top, bottom but incustom_ui_materialthe selectors switch them so left is right and top is bottom.Solution
Reverse the conditions so that the correct border values are selected.