bevy_pbr: Apply #![deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)]
#17277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hout_reason)]` to bevy_pbr
LikeLakers2
commented
Jan 10, 2025
LikeLakers2
commented
Jan 10, 2025
| @@ -1,6 +1,11 @@ | |||
| #![expect(missing_docs, reason = "Not all docs are written yet, see #3492.")] | |||
| #![cfg_attr(docsrs, feature(doc_auto_cfg))] | |||
| #![deny(unsafe_code)] | |||
| #![forbid(unsafe_code)] | |||
There was a problem hiding this comment.
I searched through bevy_pbr, and found no unsafe code - so I figured this was meant to be a forbid.
8 tasks
ickshonpe
approved these changes
Jan 10, 2025
BenjaminBrienen
approved these changes
Jan 10, 2025
BenjaminBrienen
added
C-Code-Quality
…x_lut()`, per suggestion from Benjamin
…r-loops easier to understand than `core::array::from_fn`
LikeLakers2
force-pushed
the
lint/deny_allow_and_without_reason/bevy_pbr
branch
from
1a90a60 to
53c979d
Compare
… find for-loops easier to understand than `core::array::from_fn`" This reverts commit 53c979d.
BenjaminBrienen
approved these changes
Jan 10, 2025
alice-i-cecile
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
clippy::allow_attributesandclippy::allow_attributes_without_reasonlints #17111Solution
Set the
clippy::allow_attributesandclippy::allow_attributes_without_reasonlints todeny, and bringbevy_pbrin line with the new restrictions.Testing
cargo clippy --tests --package bevy_pbrwas run, and no errors were encountered.