Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Both
set_metrics
andset_size
can trigger text re-layout and re-shaping, if the values provided are different form what is already in theBuffer
.Solution
Combine the
set_metrics
andset_size
calls.This might be a small optimization in some situations, maybe when both font size and text bounds change in the same frame, or when spawning new text.
I did measure a ~500 microsecond improvement in
text_system
formany_buttons --respawn
, but that may have just been noise.