Rename Rot2::angle_between to Rot2::angle_to
#16327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-blackbird
added
the
A-Math
tim-blackbird
added
the
D-Straightforward
Jondolf
reviewed
Nov 10, 2024
Co-authored-by: Joona Aalto <[email protected]>
Jondolf
approved these changes
Nov 10, 2024
Jondolf
reviewed
Nov 10, 2024
Co-authored-by: Joona Aalto <[email protected]>
BenjaminBrienen
added
S-Needs-Review
mockersf
approved these changes
Nov 10, 2024
tim-blackbird
added
S-Ready-For-Final-Review
BenjaminBrienen
approved these changes
Nov 10, 2024
alice-i-cecile
added
the
M-Needs-Migration-Guide
mockersf
pushed a commit
that referenced
this pull request
Nov 11, 2024
# Objective `glam` has opted to rename `Vec2::angle_between` to `Vec2::angle_to` because of the difference in semantics compared to `Vec3::angle_between` and others which return an unsigned angle `[0, PI]` where `Vec2::angle_between` returns a signed angle `[-PI, PI]`. We should follow suit for `Rot2` in 0.15 to avoid further confusion. Links: - bitshifter/glam-rs#514 (comment) - bitshifter/glam-rs#524 ## Migration Guide `Rot2::angle_between` has been deprecated, use `Rot2::angle_to` instead, the semantics of `Rot2::angle_between` will change in the future. --------- Co-authored-by: Joona Aalto <[email protected]>
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Dec 2, 2024
# Objective `glam` has opted to rename `Vec2::angle_between` to `Vec2::angle_to` because of the difference in semantics compared to `Vec3::angle_between` and others which return an unsigned angle `[0, PI]` where `Vec2::angle_between` returns a signed angle `[-PI, PI]`. We should follow suit for `Rot2` in 0.15 to avoid further confusion. Links: - bitshifter/glam-rs#514 (comment) - bitshifter/glam-rs#524 ## Migration Guide `Rot2::angle_between` has been deprecated, use `Rot2::angle_to` instead, the semantics of `Rot2::angle_between` will change in the future. --------- Co-authored-by: Joona Aalto <[email protected]>
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective `glam` has opted to rename `Vec2::angle_between` to `Vec2::angle_to` because of the difference in semantics compared to `Vec3::angle_between` and others which return an unsigned angle `[0, PI]` where `Vec2::angle_between` returns a signed angle `[-PI, PI]`. We should follow suit for `Rot2` in 0.15 to avoid further confusion. Links: - bitshifter/glam-rs#514 (comment) - bitshifter/glam-rs#524 ## Migration Guide `Rot2::angle_between` has been deprecated, use `Rot2::angle_to` instead, the semantics of `Rot2::angle_between` will change in the future. --------- Co-authored-by: Joona Aalto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
glamhas opted to renameVec2::angle_betweentoVec2::angle_tobecause of the difference in semantics compared toVec3::angle_betweenand others which return an unsigned angle[0, PI]whereVec2::angle_betweenreturns a signed angle[-PI, PI].We should follow suit for
Rot2in 0.15 to avoid further confusion.Links:
angle_betweenfunction is unclear/misleading bitshifter/glam-rs#514 (comment)Migration Guide
Rot2::angle_betweenhas been deprecated, useRot2::angle_toinstead, the semantics ofRot2::angle_betweenwill change in the future.