rtrip.py: convert to python3 #192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Python 2 reached end of life (EOL), so convert rtrip.py to python3. Signed-off-by: Mingli Yu <[email protected]>
| @@ -1,4 +1,4 @@ | |||
| #! /usr/bin/env python | |||
| #! /usr/bin/env python3 | |||
There was a problem hiding this comment.
Actually, this line isn't needed and can be removed.
| @@ -160,7 +160,7 @@ def usage(msg): | |||
|
|
|||
| Usage: | |||
|
|
|||
| python -m astor.rtrip [readonly] [<source>] | |||
| python3 -m astor.rtrip [readonly] [<source>] | |||
There was a problem hiding this comment.
astor still supports Python 2.7 (it will be dropped in either 0.9 or 1.0) and python may still point to Python 3 especially if astor is installed inside a virtual environment. I'd prefer keeping it as for now.
It would be nice to use argparse instead of the current solution, though.
|
tests/test_rtrip.py seems to fail for me on Python 3 in #208 |
|
The new Astor release will drop Python 2 support, but it requires more work than just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Python 2 reached end of life (EOL), so convert rtrip.py to python3.
Signed-off-by: Mingli Yu [email protected]