Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nose from setup.cfg #177

Closed
wants to merge 1 commit into from

Conversation

paolostivanin
Copy link

I ran the tests with python3 -m unittest2 discover and everything went fine, so I assume that those strings I'd like to remove with this PR are not really needed.

I ran the tests with `python3 -m unittest2 discover` and everything went fine, so I assume that those strings I'd like to remove with this PR are not really needed.
Copy link
Owner

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with this approach is that we would need to change tox.ini to invoke either unittest or unittest2 depending on the Python version (we still support Python 2.7) So we use nose as a Python 2 and 3 compatible test runner for now.

Also, there are more places we need to update in order to run tests on Travis CI:

.gitignore:41:nosetests.xml
requirements-tox.txt:1:nose>=1.3.0
tox.ini:11:        coverage run {envbindir}/nosetests -v --nocapture {posargs}

@berkerpeksag berkerpeksag mentioned this pull request Jan 1, 2025
18 tasks
@berkerpeksag
Copy link
Owner

Thank you for your PR! I've now replaced nose with pytest as part of PR #229.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants