Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alphabetize builds in circleci #5226

Merged
merged 1 commit into from
Nov 17, 2023
Merged

alphabetize builds in circleci #5226

merged 1 commit into from
Nov 17, 2023

Conversation

shaneknapp
Copy link
Contributor

No description provided.

ryanlovett
ryanlovett approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@ryanlovett ryanlovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! While there are some deployment dependencies (e.g. some hubs use the main datahub image), the image builds and hub deploys should be completely separate.

At one point the hubs that used the main datahub image were also configured in this file to build the image, which would result in the image being built multiple times, but I think that was fixed a couple of months back. Any hubs using the datahub image (except for datahub itself) should not have their own build-image stanza.

@shaneknapp
Copy link
Contributor Author

Makes sense! While there are some deployment dependencies (e.g. some hubs use the main datahub image), the image builds and hub deploys should be completely separate.

At one point the hubs that used the main datahub image were also configured in this file to build the image, which would result in the image being built multiple times, but I think that was fixed a couple of months back. Any hubs using the datahub image (except for datahub itself) should not have their own build-image stanza.

yeah, i am pretty sure that i'm not building hub images that are based on datahub.

@shaneknapp shaneknapp merged commit cc1021d into berkeley-dsep-infra:staging Nov 17, 2023
2 checks passed
@shaneknapp shaneknapp deleted the alphabetize-circleci branch November 17, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanlovett ryanlovett ryanlovett approved these changes

@felder felder Awaiting requested review from felder

@gmerritt gmerritt Awaiting requested review from gmerritt

Assignees
No one assigned
Labels
build-infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaneknapp @ryanlovett