Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DH-66] normalize popcon installation to the latest version on my fork #5197

Conversation

shaneknapp
Copy link
Contributor

@shaneknapp shaneknapp commented Nov 7, 2023

the purpose of this PR is five-fold:

  1. use my latest changes to popcon and handle errors, period (handle error cases yuvipanda/python-popularity-contest#3)
  2. make sure infra-reqs was updated w/the latest popcon branch
  3. update infra-reqs for all hubs
  4. confirm that infra-reqs was actually being exectued...
  5. ...and if not, explicitly install it in environment.yaml

one problem w/the popcon module was that it was failing and erroring out before pushing to statsd, which would partially explain why some hubs don't have any popcon results. once this is merged to prod, we'll be able to see if any other hubs start reporting this data... and if not, we can do spot-testing and investigate each one individually.

@shaneknapp
Copy link
Contributor Author

weeeeeird. data8 won't build that hash, and i've reproduced it on the cli:

jovyan@jupyter-sknapp:~$ pip -v install git+https://github.com/yuvipanda/python-popularity-contest@9e30ec414e45615e75a0e86424141b7093c8f686
Using pip 20.2.4 from /srv/conda/lib/python3.9/site-packages/pip (python 3.9)
Non-user install because site-packages writeable
Created temporary directory: /tmp/pip-ephem-wheel-cache-vb47pqdt
Created temporary directory: /tmp/pip-req-tracker-bpbnvi2l
Initialized build tracking at /tmp/pip-req-tracker-bpbnvi2l
Created build tracker: /tmp/pip-req-tracker-bpbnvi2l
Entered build tracker: /tmp/pip-req-tracker-bpbnvi2l
Created temporary directory: /tmp/pip-install-tzu2lkqf
Collecting git+https://github.com/yuvipanda/python-popularity-contest@9e30ec414e45615e75a0e86424141b7093c8f686
  Created temporary directory: /tmp/pip-req-build-xdme9c1e
  Cloning https://github.com/yuvipanda/python-popularity-contest (to revision 9e30ec414e45615e75a0e86424141b7093c8f686) to /tmp/pip-req-build-xdme9c1e
  778e1b4509d351f1d1ad5a68b188190724363cf8
ERROR: Command errored out with exit status 128: git checkout -q 9e30ec414e45615e75a0e86424141b7093c8f686 Check the logs for full command output.
Exception information:
Traceback (most recent call last):
  File "/srv/conda/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 228, in _main
    status = self.run(options, args)
  File "/srv/conda/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 182, in wrapper
    return func(self, options, args)
  File "/srv/conda/lib/python3.9/site-packages/pip/_internal/commands/install.py", line 323, in run
    requirement_set = resolver.resolve(
  File "/srv/conda/lib/python3.9/site-packages/pip/_internal/resolution/legacy/resolver.py", line 183, in resolve
    discovered_reqs.extend(self._resolve_one(requirement_set, req))
  File "/srv/conda/lib/python3.9/site-packages/pip/_internal/resolution/legacy/resolver.py", line 388, in _resolve_one
    abstract_dist = self._get_abstract_dist_for(req_to_install)
  File "/srv/conda/lib/python3.9/site-packages/pip/_internal/resolution/legacy/resolver.py", line 340, in _get_abstract_dist_for
    abstract_dist = self.preparer.prepare_linked_requirement(req)
  File "/srv/conda/lib/python3.9/site-packages/pip/_internal/operations/prepare.py", line 467, in prepare_linked_requirement
    local_file = unpack_url(
  File "/srv/conda/lib/python3.9/site-packages/pip/_internal/operations/prepare.py", line 239, in unpack_url
    unpack_vcs_link(link, location)
  File "/srv/conda/lib/python3.9/site-packages/pip/_internal/operations/prepare.py", line 99, in unpack_vcs_link
    vcs_backend.unpack(location, url=hide_url(link.url))
  File "/srv/conda/lib/python3.9/site-packages/pip/_internal/vcs/versioncontrol.py", line 733, in unpack
    self.obtain(location, url=url)
  File "/srv/conda/lib/python3.9/site-packages/pip/_internal/vcs/versioncontrol.py", line 641, in obtain
    self.fetch_new(dest, url, rev_options)
  File "/srv/conda/lib/python3.9/site-packages/pip/_internal/vcs/git.py", line 243, in fetch_new
    self.run_command(cmd_args, cwd=dest)
  File "/srv/conda/lib/python3.9/site-packages/pip/_internal/vcs/versioncontrol.py", line 771, in run_command
    return call_subprocess(cmd, cwd,
  File "/srv/conda/lib/python3.9/site-packages/pip/_internal/vcs/versioncontrol.py", line 166, in call_subprocess
    raise SubProcessError(exc_msg)
pip._internal.exceptions.SubProcessError: Command errored out with exit status 128: git checkout -q 9e30ec414e45615e75a0e86424141b7093c8f686 Check the logs for full command output.
Removed build tracker: '/tmp/pip-req-tracker-bpbnvi2l'

i'm not quite sure what's going on here... :\

@shaneknapp shaneknapp changed the title [DH-66] bump popcon on remaining hubs [DH-66] normalize popcon installation to the latest version on my fork Nov 7, 2023
@shaneknapp shaneknapp merged commit 9488b62 into berkeley-dsep-infra:staging Nov 8, 2023
2 checks passed
@shaneknapp shaneknapp deleted the upgrade-remaining-hubs-popularity branch November 8, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment