Skip to content

Commit

Permalink
Allow GenerateCodesigningDossier to run in a sandbox and remotely (#…
Browse files Browse the repository at this point in the history
…2509)

This was incorrectly added. It doesn’t do code signing, so it doesn’t
need to have special execution requirements.

---------

Signed-off-by: Brentley Jones <[email protected]>
  • Loading branch information
brentleyjones authored Aug 6, 2024
1 parent 04b1b72 commit 4b40a88
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions apple/internal/codesigning_support.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -510,12 +510,6 @@ def _generate_codesigning_dossier_action(

dossier_arguments = ["--output", output_dossier.path, "--zip"]

execution_requirements = {
# Unsure, but may be needed for keychain access, especially for files
# that live in $HOME.
"no-sandbox": "1",
}

# Try to use the identity passed on the command line, if any. If it's a simulator build, use an
# ad hoc identity.
codesign_identity = _preferred_codesigning_identity(platform_prerequisites)
Expand All @@ -542,11 +536,6 @@ def _generate_codesigning_dossier_action(
# Only reference and embed the provisioning profile in standard code signing.
input_files.append(provisioning_profile)
dossier_arguments.extend(["--provisioning_profile", provisioning_profile.path])
if platform_prerequisites.platform.is_device:
# Added so that the output of this action is not cached remotely,
# in case multiple developers sign the same artifact with different
# identities.
execution_requirements["no-remote"] = "1"

for embedded_dossier in embedded_dossiers:
input_files.append(embedded_dossier.dossier_file)
Expand All @@ -572,7 +561,6 @@ def _generate_codesigning_dossier_action(
apple_fragment = platform_prerequisites.apple_fragment,
arguments = args,
executable = dossier_codesigningtool,
execution_requirements = execution_requirements,
inputs = input_files,
mnemonic = mnemonic,
outputs = [output_dossier],
Expand Down

0 comments on commit 4b40a88

Please sign in to comment.