Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(debug): Launch Extension Tests with Debug Server #423

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

cwahbong
Copy link
Contributor

@cwahbong cwahbong commented Oct 23, 2024

So that we can easily debugging the test cases.

Referencing https://github.com/microsoft/vscode-test-cli/tree/ca11885/?tab=readme-ov-file#debugging

BEGIN_COMMIT_OVERRIDE
chore(debug): Launch Extension Tests with Debug Server
END_COMMIT_OVERRIDE

So that we can easily debugging the test cases.
@cwahbong cwahbong changed the title feat(debug): Launch testing + debug feat(debug): Launch Extension Tests with Debug Server Oct 23, 2024
@vogelsgesang vogelsgesang changed the title feat(debug): Launch Extension Tests with Debug Server chore(debug): Launch Extension Tests with Debug Server Oct 23, 2024
@vogelsgesang
Copy link
Collaborator

renamed this from feat(debug) to chore(debug), as this is not a customer-facing feature.

We actually do have a customer-facing "debug" feature, but that is about debugging Starlark code, and I don't want to have any confusion around this in our release notes

@vogelsgesang vogelsgesang merged commit 81fe29d into bazel-contrib:master Oct 23, 2024
1 check passed
@vogelsgesang
Copy link
Collaborator

vogelsgesang commented Oct 23, 2024

🤦 and I merged it with the wrong commit message. Still with feat in the name...

@cameron-martin
Copy link
Collaborator

You can fix the release notes by editing the PR description: https://github.com/googleapis/release-please?tab=readme-ov-file#how-can-i-fix-release-notes

@cwahbong cwahbong deleted the launch-test-debug branch October 24, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants