Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(workspace-tree): Refine event and dispose handling #420

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

cwahbong
Copy link
Contributor

Less dependency for BazelWorkspaceTreeProvider, making the future testing changes simpler.

Also small clean ups for this capturing and making the styles (naming and initializations) like
https://github.com/microsoft/vscode-extension-samples/blob/2f83557/tree-view-sample/src/nodeDependencies.ts

Less dependency for BazelWorkspaceTreeProvider, making the future
testing changes simpler.
@cwahbong cwahbong requested a review from vogelsgesang October 20, 2024 07:05
@cwahbong
Copy link
Contributor Author

The rest of work for workspace handling external dependency is still without test cases (it-works-on-my-machines), thus uploading only a change without much behavior change first.

@cwahbong cwahbong changed the title refactor(workspace-tree): refine event and dispose handling refactor(workspace-tree): Refine event and dispose handling Oct 20, 2024
@vogelsgesang vogelsgesang merged commit b01fdbc into bazel-contrib:master Oct 20, 2024
1 check passed
@vogelsgesang
Copy link
Collaborator

The rest of work for workspace handling external dependency is still without test cases (it-works-on-my-machines), thus uploading only a change without much behavior change first.

Thanks for the context! Sounds good. Even independent of any future changes, this is definitely an improvement. Great work, keep it going 🙂

By the way: You can reach me and the other maintainers of this extension on https://slack.bazel.build/, in case you want to discuss architecture / code design / ...

@cwahbong cwahbong deleted the workspace-tree-dispose branch October 20, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants