Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for relative target completion #306

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

kon72
Copy link
Contributor

@kon72 kon72 commented Nov 5, 2023

This change enables the target completion to work with relative label starting with colon.

Depends on #305

@kon72 kon72 force-pushed the relative-target-completion branch 2 times, most recently from a72602e to 9c6de13 Compare November 6, 2023 03:02
@jfirebaugh jfirebaugh force-pushed the relative-target-completion branch from 9c6de13 to 1402ddd Compare December 15, 2023 21:19
@jfirebaugh
Copy link
Collaborator

Thanks! I took the liberty of rebasing this on current master after merging #305. Do you think this and #307 are ready for review?

@kon72 kon72 marked this pull request as ready for review December 16, 2023 13:55
@kon72
Copy link
Contributor Author

kon72 commented Dec 16, 2023

HI @jfirebaugh,

Thanks for the rebasing! I think this change is good to go.

For #307, I'm wondering if it may introduce some performance degradation, so I will do some more investigation and add an option for users to opt out of external rule completion.

Copy link
Collaborator

@jfirebaugh jfirebaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Out of curiosity, are you familiar with testing VS Code extensions? (I've never done it before.) Code completion seems like the sort of thing that would be nice to have tests around. No worries if not!

@cpsauer
Copy link

cpsauer commented Jan 5, 2024

@kon72, thanks for working on these!

@kon72 kon72 requested a review from cameron-martin as a code owner January 31, 2024 20:41
@jfirebaugh jfirebaugh enabled auto-merge (squash) January 31, 2024 20:41
@jfirebaugh jfirebaugh merged commit 0f04c11 into bazel-contrib:master Jan 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants