Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Deduplicate deps while amending #1266

Merged
merged 4 commits into from
Nov 13, 2024
Merged

fix: Deduplicate deps while amending #1266

merged 4 commits into from
Nov 13, 2024

Conversation

honnix
Copy link
Contributor

@honnix honnix commented Oct 11, 2024

To address #1251 (comment)

@honnix
Copy link
Contributor Author

honnix commented Oct 18, 2024

Does this change make sense? Can someone help review it? Thanks.

@honnix honnix mentioned this pull request Oct 21, 2024
Closed
@jin
Copy link
Collaborator

jin commented Nov 5, 2024

(responding in this PR because this came first, but #1269 also appears to solve the same thing)

cc @shs96c who wrote the parent PR

Can you add comments like in #1269, and regression build tests by adding the triggering artifacts in #1267 to

rules_jvm_external/MODULE.bazel

Line 501 in 1202665

name = "regression_testing_coursier",
and

rules_jvm_external/tests/unit/build_tests/BUILD

Line 7 in 1202665

build_test(
?

jin
jin reviewed Nov 5, 2024
View reviewed changes
private/rules/coursier.bzl Outdated Show resolved Hide resolved
private/rules/coursier.bzl Show resolved Hide resolved
@honnix
Copy link
Contributor Author

honnix commented Nov 5, 2024

I added a few more commits, but please feel free to take #1269 instead and cherry pick useful commits from this PR.

@honnix
Copy link
Contributor Author

honnix commented Nov 11, 2024

Shall we move forward with this? I'm fine either this PR or #1269. Thanks.

@jin jin merged commit d78a1c3 into bazel-contrib:master Nov 13, 2024
7 checks passed
@jin
Copy link
Collaborator

jin commented Nov 13, 2024

Thanks, sorry for the delay.

@honnix honnix deleted the dedupe branch November 13, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jin jin jin approved these changes

@shs96c shs96c Awaiting requested review from shs96c shs96c is a code owner

@cheister cheister Awaiting requested review from cheister cheister is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@honnix @jin