Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload characteristics working modifications #94

Open
wants to merge 2 commits into
base: Development
Choose a base branch
from

Conversation

ivanbazina
Copy link

Querstion in comment on line 1394:
Should maxDataPacketSize be set to maxPacketSize - 2 because checksum length is 2 and it is also calculated in packet size?

@chrisb2
Copy link

chrisb2 commented Apr 27, 2020

Should maxDataPacketSize be set to maxPacketSize - 2 because checksum length is 2 and it is also calculated in packet size?

The "Package Length" in the package is described as: "Refers to the length of package content (command packets and data packets) plus the length of Checksum( 2 bytes)." If maxDataPacketSize configured for sensor is 32, then the checksum length will be 34 for full size packages. Have confirmed this by dumping package to log file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants