-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3978 #4110
Merged
Merged
#3978 #4110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…内にHelperのnamespaceとclassnameの変更処理を移動
namespaceとクラス名変更を1つの関数にまとめた。helperが複数あっても対応可能にした。helperの名前がテーマ名と違っても対応可能にした。
@IwasakiRyuichi コンフリクトしているので修正をお願いします。 |
@ryuring |
@IwasakiRyuichi コンフリクトのままですね。
まず、このレポジトリは、 まずは、本家を追加して、本家の
|
@ryuring |
一旦マージしますので、ユニットテストの実装をお願いします。 @IwasakiRyuichi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ryuring
午前に言われた対応行いました。
BcThemeSampleにBcThemeTestHelperという2つ目のヘルパーを新しく作成し、コピーを実行するとBcThemeTestCopyHelperが作られ、正常に画面の表示も確認できましたので機能実装はできていると思われます。
お手隙の際にご確認いただければと思います。よろしくお願いいたします。