add unitTest_MailConfigsController_index #3425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HungDV2022
reviewed
May 16, 2024
plugins/bc-mail/tests/TestCase/Controller/Admin/MailConfigsControllerTest.php
Outdated
Show resolved
Hide resolved
HungDV2022
reviewed
May 16, 2024
plugins/bc-mail/tests/TestCase/Controller/Admin/MailConfigsControllerTest.php
Outdated
Show resolved
Hide resolved
ryuring
reviewed
May 17, 2024
| parent::setUp(); | ||
| $this->loadFixtureScenario(InitAppScenario::class); | ||
| $this->MailConfigsController = new MailConfigsController($this->loginAdmin($this->getRequest())); |
There was a problem hiding this comment.
@thangnnmd @HungDV2022 この行は使ってないですね
There was a problem hiding this comment.
@thangnnmd
làm giống thằng này xem nhé a
#3423 (comment)
There was a problem hiding this comment.
@ryuring
こちらを調整しました。確認お願いします。
ryuring
requested changes
May 20, 2024
| */ | ||
| use ScenarioAwareTrait; | ||
|
|
||
| public $MailConfigsController; |
There was a problem hiding this comment.
@thangnnmd @HungDV2022 これは不要ですね
There was a problem hiding this comment.
@ryuring こちらを修正しました。確認お願いします。
| @@ -34,8 +39,7 @@ public function setUp(): void | |||
| */ | |||
| public function tearDown(): void | |||
| { | |||
| // unset($this->MailConfigs); | |||
| // unset($this->Case); | |||
| unset($this->MailConfigsController); | |||
There was a problem hiding this comment.
@thangnnmd @HungDV2022 これは不要ですね
There was a problem hiding this comment.
@ryuring こちらを修正しました。確認お願いします。
|
ありがとうございます、マージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add unitTest_MailConfigsController_index