Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Admin_MailFieldsController_add #3344

Merged
merged 2 commits into from
Apr 20, 2024
Merged

add Admin_MailFieldsController_add #3344

merged 2 commits into from
Apr 20, 2024

Conversation

thangnnmd
Copy link
Collaborator

add Admin_MailFieldsController_add

@HungDV2022
Copy link
Collaborator

@ryuring レビューをお願いします。

@HungDV2022 HungDV2022 assigned ryuring and unassigned HungDV2022 Apr 15, 2024
@ryuring ryuring assigned HungDV2022 and thangnnmd and unassigned ryuring Apr 16, 2024
@ryuring ryuring added the Reviewed レビュー済 label Apr 16, 2024
@ryuring
Copy link
Collaborator

ryuring commented Apr 16, 2024

@HungDV2022 @thangnnmd こちらも、 #3338 (comment) と同様に、イベントのテストの追加をお願いします。

@thangnnmd thangnnmd removed their assignment Apr 17, 2024
@HungDV2022
Copy link
Collaborator

@HungDV2022 @thangnnmd こちらも、 #3338 (comment) と同様に、イベントのテストの追加をお願いします。

@ryuring イベントのテストは別PRに調整しました。確認お願いします。

@HungDV2022 HungDV2022 assigned ryuring and unassigned HungDV2022 Apr 17, 2024
@momofff momofff added this to the 5.1.0 milestone Apr 18, 2024
@ryuring
Copy link
Collaborator

ryuring commented Apr 20, 2024

了解しました、マージします。

@ryuring ryuring merged commit 5b34446 into baserproject:dev-5.1 Apr 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed レビュー済
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants