feat: updating schema mapping to support additional column metadata. #62
+125
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 17, 2024 16:38
…lacing with rule update.
barakalon
reviewed
Dec 19, 2024
added 7 commits
January 7, 2025 10:44
barakalon
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, mysql-mimic can only support passing in the column name and type when constructing the MySQL information schema. This PR adds support for specifying column values for the comment, default, and is_nullable fields in a dictionary at the column level.
The existing code works by making some inferences based on the dictionary depth, so this change supports both formats by checking whether the innermost dictionary contains column metadata, and adjusting the expected depth accordingly.