Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable assignment & visualisation with partial query graphs #332

Merged
merged 39 commits into from
Nov 7, 2024

Conversation

nickjcroucher
Copy link
Collaborator

To enable full database querying with beebop:

  • This workflow saves a partial query graph after assignment, along with a list of the sequences in the network components containing queries
  • This enables visusaliation of only the clusters that contain queries, rather than the full database
  • A flag is added to enable distances to be recalculated for tree generation, rather than read from the file (question: would it be useful to have an option in which we sparsified the pairwise distance matrix to only include within-cluster distances?)
  • I update the CI tests to allow testing of the beebop workflow
  • This revealed a problem with the lineage assignment C++ code, which I think should now be resolved

@johnlees
Copy link
Member

johnlees commented Nov 6, 2024

@nickjcroucher is this ready for review? I feel we should release and fix the conda builds as the dict bug keeps coming up

@nickjcroucher
Copy link
Collaborator Author

Yes! Sorry, I was still making some fixes with @absternator yesterday, but it should now be working

PopPUNK/__init__.py Outdated Show resolved Hide resolved
PopPUNK/assign.py Show resolved Hide resolved
PopPUNK/models.py Outdated Show resolved Hide resolved
PopPUNK/network.py Outdated Show resolved Hide resolved
PopPUNK/network.py Outdated Show resolved Hide resolved
PopPUNK/plot.py Outdated Show resolved Hide resolved
src/extend.cpp Outdated Show resolved Hide resolved
PopPUNK/sketchlib.py Show resolved Hide resolved
PopPUNK/visualise.py Show resolved Hide resolved
test/test-update.py Outdated Show resolved Hide resolved
@johnlees johnlees merged commit a372e4d into master Nov 7, 2024
3 checks passed
@johnlees johnlees deleted the opt_query_viz branch November 7, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants