Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/minify #4

Merged
merged 7 commits into from
Jan 13, 2025
Merged

F/minify #4

merged 7 commits into from
Jan 13, 2025

Conversation

maurolacy
Copy link
Collaborator

Added some extra minifying tools to reduce smart contracts size slightly (~2%).

Not sure we want to merge this, as the improvements are minimal, and it also departs a bit from upstream.

Copy link
Member

@SebastianElvis SebastianElvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reference for the minify technique and does this come from the optimiser upstream?

Base automatically changed from release-0.16.1 to main January 13, 2025 08:40
@maurolacy
Copy link
Collaborator Author

maurolacy commented Jan 13, 2025

Is there a reference for the minify technique and does this come from the optimiser upstream?

Nah, this comes from my research on NEAR 🙂. Here's a reference: https://github.com/near/near-sdk-rs/blob/master/minifier/minify.sh

I just wanted to check how much it improved size reduction. So, here it is.

Copy link
Member

@SebastianElvis SebastianElvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

Dockerfile Show resolved Hide resolved
@maurolacy maurolacy merged commit 91a128a into main Jan 13, 2025
@maurolacy maurolacy deleted the f/minify branch January 13, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants