-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed identifier assigner added #45
base: release-candidate
Are you sure you want to change the base?
fixed identifier assigner added #45
Conversation
Codecov Report
@@ Coverage Diff @@
## release-candidate #45 +/- ##
===================================================
Coverage 100.00% 100.00%
===================================================
Files 35 35
Lines 1376 1395 +19
===================================================
+ Hits 1376 1395 +19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@mtabacman I will let you comment on this. I don't get why we need to configure the |
@gcotelli Indeed Willow's I guess we could think of an enhancement of |
The changes are not compatible with the responsibilities expected of the object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IF we decide that Boardwalk for some reason needs something polymorphic with an IdentifierAssigner that always assigns the same id, it should be made using a new object with compatible protocol, but not with a new message that changes the IdentifierAssigner to do nothing at all and be filled with configurable nothingness :-)
changes for add the fixed identifier assigner