Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor. Updating module logic #41

Merged
merged 1 commit into from
Sep 13, 2024
Merged

refactor. Updating module logic #41

merged 1 commit into from
Sep 13, 2024

Conversation

pangolp
Copy link
Contributor

@pangolp pangolp commented Sep 13, 2024

Changes Proposed:

  • PlayerScript logic is replaced by ServerScript
  • All loot is added to the body of an NPC, removing the content from the rest of those within the area, which by default are 55f.

Issues Addressed:

  • Closes

SOURCE:

Tests Performed:

  • Windows 10
  • In-game

How to Test the Changes:

  1. Clone the repository
  2. Update the emulator
  3. Kill a series of NPCs and you will be able to observe that all the loot, as long as it is less than 15 items, will go to a single body, being eliminated from the rest.

@pangolp pangolp marked this pull request as ready for review September 13, 2024 08:19
@Helias Helias merged commit 3e252f4 into azerothcore:master Sep 13, 2024
1 check passed
@pangolp
Copy link
Contributor Author

pangolp commented Sep 13, 2024

Thanks @Helias

@pangolp pangolp deleted the refactor branch September 13, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pangolp @Helias