Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore. update readme #36

Merged
merged 1 commit into from
Mar 20, 2024
Merged

chore. update readme #36

merged 1 commit into from
Mar 20, 2024

Conversation

pangolp
Copy link
Contributor

@pangolp pangolp commented Mar 20, 2024

Important note

  • Do not approve the PR, because I want to add it as a coauthor, so it appears in the list of contributors.
  • Co-authored-by: M'Dic [email protected]
  • Co-authored-by: Nefertumm [email protected]

Changes Proposed:

  • I need to modify the readme file again, because I need to add a little information about the delay of bodies, which is an important issue, and I'll take the opportunity to clean up the readme file a little, but I read your suggestions for possible changes.

Issues Addressed:

  • Closes

SOURCE:

Tests Performed:

How to Test the Changes:

@pangolp pangolp requested a review from FrancescoBorzi March 20, 2024 20:08
@pangolp
Copy link
Contributor Author

pangolp commented Mar 20, 2024

@Kaev It won't let me add you to the review, but give me your opinion too, to see if you think it is correct or if something else needs to be added. Thank you. I also have to add Nefertum, because he was testing and helping me with some tests, although some things were discarded, he was also collaborating.

@pangolp
Copy link
Contributor Author

pangolp commented Mar 20, 2024

Sorry, I'm going to make the changes, because they seem important to me, but feel free to add or make modifications in the future. I had not realized that since the pull request had not been merged, their ideas were not going to be taken into account.

@pangolp pangolp merged commit bb2d718 into azerothcore:master Mar 20, 2024
1 check passed
@pangolp pangolp deleted the readme branch March 20, 2024 20:38
@pangolp pangolp removed the request for review from FrancescoBorzi March 20, 2024 20:52
@Kaev
Copy link
Member

Kaev commented Mar 20, 2024

@Kaev It won't let me add you to the review, but give me your opinion too, to see if you think it is correct or if something else needs to be added. Thank you. I also have to add Nefertum, because he was testing and helping me with some tests, although some things were discarded, he was also collaborating.

All good, i just was a middleman to clarify the credits situation with acidmanifesto. I just made the PR because nobody else did it.

@pangolp
Copy link
Contributor Author

pangolp commented Mar 20, 2024

All good, i just was a middleman to clarify the credits situation with acidmanifesto. I just made the PR because nobody else did it.

I didn't understand anything that was happening this morning when I saw that message. I was missing context. And it also happened to me that I didn't see that I wasn't part of the collaborators (I thought I was). And I also took the opportunity to add him to Nefertum, with whom I had some voice calls, and we did tests... he also sometimes helps me with some things when he has some time.

@Kaev
Copy link
Member

Kaev commented Mar 21, 2024

Best case is you talk to Shin directly, he can explain the situation to you.
I'm sorry for the confusion that my PR created.

@pangolp
Copy link
Contributor Author

pangolp commented Mar 21, 2024

Best case is you talk to Shin directly, he can explain the situation to you.
I'm sorry for the confusion that my PR created.

No, no problem. I already spoke with him. Now I have context. But I had that for breakfast, without context, and I didn't understand anything. Because generally, I don't name anyone. But not because I don't give credits, but because generally, they already have a previous job or something. In this case, there was no commit, so it had been left out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants