Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add new workflow to sync i18n files #3215

Merged
merged 3 commits into from
Dec 27, 2024
Merged

Conversation

Exitare
Copy link
Member

@Exitare Exitare commented Dec 23, 2024

Using en.json as default to sync all keys across the available json files.
Commits the adjustments if necessary.
Closes #3211

Example fix can be seen here:
Exitare@435a29e

scripts/sync_i18n.py Outdated Show resolved Hide resolved
scripts/sync_i18n.py Outdated Show resolved Hide resolved
@Helias Helias changed the title Add new workflow to sync i18n files ci: add new workflow to sync i18n files Dec 24, 2024
@Helias
Copy link
Member

Helias commented Dec 24, 2024

I like a lot this PR 🚀

@Exitare
Copy link
Member Author

Exitare commented Dec 25, 2024

Done ;)

scripts/sync_i18n.py Outdated Show resolved Hide resolved
@Helias Helias merged commit 4442cc8 into azerothcore:master Dec 27, 2024
12 checks passed
@Helias
Copy link
Member

Helias commented Dec 27, 2024

Thanks a lot!

@FrancescoBorzi
Copy link
Collaborator

@Exitare @Helias the build is failing on master branch

@Exitare
Copy link
Member Author

Exitare commented Dec 28, 2024

@FrancescoBorzi because it's not allowed to push on the protected branch. What's the preferred solution here?

@FrancescoBorzi
Copy link
Collaborator

@Exitare the preferred solution would be having it in the branch instead of on main, so we could disable this check on main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18n files are not in sync.
3 participants