Skip to content

Commit

Permalink
Remove unneeded serde feature on byte-unit dep (nushell#13749)
Browse files Browse the repository at this point in the history
removing the `std` feature as well would drop some dependencies tied to
`rust_decimal` from the `Cargo.lock` but unclear to me what the actual
impact on compile times is.

We may want to consider dropping the `byte-unit` dependency altogether
as we have a significant fraction of our own logic to support the byte
units with 1024 and 1000 prefixes. Not sure which fraction is covered by
us or the dependency.
  • Loading branch information
sholderbach authored Sep 1, 2024
1 parent e3f5991 commit ee997ef
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion crates/nu-protocol/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ nu-derive-value = { path = "../nu-derive-value", version = "0.97.2" }

brotli = { workspace = true, optional = true }
bytes = { workspace = true }
byte-unit = { version = "5.1", features = [ "serde" ] }
byte-unit = { version = "5.1" }
chrono = { workspace = true, features = [ "serde", "std", "unstable-locales" ], default-features = false }
chrono-humanize = { workspace = true }
dirs = { workspace = true }
Expand Down

0 comments on commit ee997ef

Please sign in to comment.