no test is not an error

awslabs · Oct 10, 2023 · 4f539fb · 4f539fb
1 parent ce775ed
commit 4f539fb
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/builder/actions/cmake.py b/builder/actions/cmake.py
@@ -246,15 +246,13 @@ def run(self, env):
             return
 
         ctest = toolchain.ctest_binary()
-        try:
-            sh.exec(*toolchain.shell_env, ctest,
-                    "--output-on-failure", working_dir=project_build_dir, check=True)
-        except:
-            # Skip generate the coverage report on error
-            return
-        # If CTest found no test, generate coverage will hang
         sh.exec(*toolchain.shell_env, ctest,
-                "-T", "coverage", working_dir=project_build_dir, check=True)
+                "--output-on-failure", working_dir=project_build_dir, check=True)
+        if env.args.coverage:
+            # Only generate coverage when required to
+            # If CTest found no test, generate coverage will hang
+            sh.exec(*toolchain.shell_env, ctest,
+                    "-T", "coverage", working_dir=project_build_dir, check=True)
 
     def __str__(self):
         return 'ctest {} @ {}'.format(self.project.name, self.project.path)