SQLServer glue get table api issue fix #2524
Open
+30
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdulR3hman
force-pushed
the
sqlserver_phase2_tablelist_issue
branch
from
0c8056b to
1bc6a1f
Compare
AbdulR3hman
approved these changes
Jan 21, 2025
AbdulR3hman
requested changes
Jan 21, 2025
ritiktrianz
force-pushed
the
sqlserver_phase2_tablelist_issue
branch
from
1bc6a1f to
a635a26
Compare
AbdulR3hman
force-pushed
the
sqlserver_phase2_tablelist_issue
branch
from
a635a26 to
06a68ad
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2524 +/- ##
=========================================
Coverage 61.21% 61.21%
Complexity 3756 3756
=========================================
Files 577 577
Lines 21435 21435
Branches 2659 2659
=========================================
Hits 13122 13122
Misses 7042 7042
Partials 1271 1271 ☔ View full report in Codecov by Sentry. |
Thanks for the update, seems like it passing now. |
AbdulR3hman
force-pushed
the
sqlserver_phase2_tablelist_issue
branch
from
06a68ad to
550af16
Compare
AbdulR3hman
approved these changes
Jan 21, 2025
…due to a case-sensitivity issue with the PARTITION_NUMBER. By converting the PARTITION_NUMBER column to lowercase, we achieved successful data retrieval through the Glue API.
…due to a case-sensitivity issue with the PARTITION_NUMBER. By converting the PARTITION_NUMBER column to lowercase, we achieved successful data retrieval through the Glue API.
AbdulR3hman
force-pushed
the
sqlserver_phase2_tablelist_issue
branch
from
550af16 to
ee2c964
Compare
chngpe
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The SQL Server Glue Get Table API was not retrieving data as expected due to a case-sensitivity issue with the PARTITION_NUMBER.
Description of changes:
Firstly by following PR #2523 of reverting back preview version and By converting the PARTITION_NUMBER column to lowercase, we achieved successful data retrieval through the Glue API.
PFA, test doc with and without glue
SQLSERVER_PH2.xlsx
SQLSERVER_FUNCTIONAL_TEST_2025-01-17_13_46_37.009157 1.csv
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.