Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snowflake package size issue fix #1719

Merged
merged 2 commits into from
Jan 22, 2024
Merged

snowflake package size issue fix #1719

merged 2 commits into from
Jan 22, 2024

Conversation

namratas-trianz
Copy link
Contributor

Issue #, if available:
Snowflake Package Is Oversized
Description of changes:
Updated code to use assembly plugin.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AbdulR3hman
AbdulR3hman requested changes Jan 19, 2024
View reviewed changes
athena-snowflake/athena-snowflake.yaml Show resolved Hide resolved
athena-snowflake/assembly.xml
<dependencySet>
<outputDirectory>lib</outputDirectory>
<excludes>
<exclude>${project.groupId}:${project.artifactId}:jar:*</exclude>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add this to the list of excludes:

            <excludes>
                <exclude>**/*.dylib</exclude>
                <exclude>**/*.dll</exclude>
                <exclude>META-INF/*.SF</exclude>
                <exclude>META-INF/*.DSA</exclude>
                <exclude>META-INF/*.RSA</exclude>
                <exclude>**/Log4j2Plugins.dat</exclude>
            </excludes>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AbdulR3hman, Using assembly plugin, we are using the format as zip and same is reflected in codeuri.
CodeUri: "./target/athena-snowflake.zip"

regarding exclusions, snowflake connector does not have these dependencies, so i have not excluded it.

@AbdulR3hman
Copy link
Contributor

this Closes #1682

@AbdulR3hman AbdulR3hman merged commit 39be279 into awslabs:master Jan 22, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 22, 2024
Cut release 2024.3.1
b88521a 
  - build(deps): bump aws-sdk.version from 1.12.637 to 1.12.641 (#1721)
  - build(deps): bump aws-sdk.version from 1.12.637 to 1.12.641
  - build(deps): bump software.amazon.msk:aws-msk-iam-auth from 2.0.2 to 2.0.3 (#1722)
  - build(deps): bump software.amazon.msk:aws-msk-iam-auth
  - snowflake package size issue fix (#1719)
  - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client from 8.11.4 to 8.12.0 (#1720)
  - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client
  - Adding extra cleanup procedures before executing release tests  (#1717)
  - build(deps): bump com.google.cloud:google-cloud-bigquery from 2.35.0 to 2.36.0 (#1714)
  - build(deps): bump com.google.cloud:google-cloud-bigquery
  - build(deps): bump io.lettuce:lettuce-core from 6.3.0.RELEASE to 6.3.1.RELEASE (#1713)
  - build(deps): bump io.lettuce:lettuce-core
  - build(deps): bump com.google.cloud:google-cloud-resourcemanager from 1.34.0 to 1.35.0 (#1707)
  - build(deps): bump com.google.cloud:google-cloud-resourcemanager
  - build(deps): bump aws-sdk.version from 1.12.632 to 1.12.637 (#1703)
  - build(deps): bump aws-sdk.version from 1.12.632 to 1.12.637
  - build(deps): bump org.eclipse.rdf4j:rdf4j-repository-sparql from 3.6.3 to 3.7.7 (#1709)
  - build(deps): bump org.eclipse.rdf4j:rdf4j-repository-sparql
  - build(deps): bump surefire.failsafe.version from 3.2.3 to 3.2.5 (#1711)
  - build(deps): bump surefire.failsafe.version from 3.2.3 to 3.2.5
  - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client from 8.11.3 to 8.11.4 (#1716)
  - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client
  - build(deps): bump software.amazon.jsii:jsii-runtime from 1.93.0 to 1.94.0 (#1712)
  - build(deps): bump software.amazon.jsii:jsii-runtime
  - build(deps): bump com.google.cloud:google-cloud-storage from 2.30.1 to 2.31.0 (#1710)
  - build(deps): bump com.google.cloud:google-cloud-storage
  - build(deps): bump com.google.protobuf:protobuf-java from 3.25.1 to 3.25.2 (#1708)
  - build(deps): bump com.google.protobuf:protobuf-java
  - build(deps): bump com.amazon.redshift:redshift-jdbc42 from 2.1.0.24 to 2.1.0.25 (#1705)
  - build(deps): bump com.amazon.redshift:redshift-jdbc42
  - build(deps-dev): bump nl.jqno.equalsverifier:equalsverifier from 3.15.5 to 3.15.6 (#1706)
  - build(deps-dev): bump nl.jqno.equalsverifier:equalsverifier
  - build(deps): bump slf4j-log4j.version from 2.0.10 to 2.0.11 (#1704)
  - build(deps): bump slf4j-log4j.version from 2.0.10 to 2.0.11
  - Reduce Maven logging levels  (#1700)
  - Reducing Maven Logging level; and increase Assume Role timeout (#1699)
  - Remove explicit use of AWS Creds in Release Tests --  (#1697)
  - Change L2 redshift construct to L1 (#1694)
  - Remove direct dependency of Netty (#1692)
  - build(deps): bump actions/setup-java from 3 to 4 (#1629)
  - Merge branch 'master' into dependabot/github_actions/actions/setup-java-4
  - improve transitive dependency for with-arrow uber jar (#1691)
  - Merge branch 'master' into dependabot/github_actions/actions/setup-java-4
  - build(deps): bump org.junit.support:testng-engine from 1.0.4 to 1.0.5 (#1689)
  - Merge branch 'master' into dependabot/maven/org.junit.support-testng-engine-1.0.5
  - build(deps): bump org.junit.support:testng-engine from 1.0.4 to 1.0.5
  - build(deps): bump aws-sdk.version from 1.12.631 to 1.12.632 (#1688)
  - build(deps): bump aws-sdk.version from 1.12.631 to 1.12.632
  - build(deps): bump github/codeql-action from 2 to 3 (#1656)
  - Merge branch 'master' into dependabot/github_actions/github/codeql-action-3
  - build(deps): bump com.google.guava:guava from 32.1.3-jre to 33.0.0-jre (#1669)
  - build(deps): bump github/codeql-action from 2 to 3
  - Merge branch 'master' into dependabot/maven/com.google.guava-guava-33.0.0-jre
  - modifying maven push to not skip checks on pull_request (#1684)
  - build(deps): bump com.google.guava:guava from 32.1.3-jre to 33.0.0-jre
  - build(deps): bump fasterxml.jackson.version from 2.16.0 to 2.16.1 (#1672)
  - build(deps): bump fasterxml.jackson.version from 2.16.0 to 2.16.1
  - build(deps): bump com.google.cloud:google-cloud-resourcemanager from 1.33.0 to 1.34.0 (#1661)
  - build(deps): bump com.google.cloud:google-cloud-resourcemanager
  - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client from 8.11.2 to 8.11.3 (#1662)
  - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client
  - build(deps): bump software.amazon.msk:aws-msk-iam-auth from 2.0.1 to 2.0.2 (#1664)
  - build(deps): bump software.amazon.msk:aws-msk-iam-auth
  - build(deps): bump org.testng:testng from 7.8.0 to 7.9.0 (#1680)
  - build(deps): bump org.testng:testng from 7.8.0 to 7.9.0
  - build(deps-dev): bump log4j2Version from 2.22.0 to 2.22.1 (#1679)
  - build(deps-dev): bump log4j2Version from 2.22.0 to 2.22.1
  - build(deps): bump com.amazon.redshift:redshift-jdbc42 from 2.1.0.23 to 2.1.0.24 (#1663)
  - build(deps): bump com.amazon.redshift:redshift-jdbc42
  - build(deps): bump slf4j-log4j.version from 2.0.9 to 2.0.10 (#1677)
  - build(deps): bump slf4j-log4j.version from 2.0.9 to 2.0.10
  - build(deps): bump org.assertj:assertj-core from 3.24.2 to 3.25.1 (#1686)
  - build(deps): bump org.assertj:assertj-core from 3.24.2 to 3.25.1
  - build(deps): bump aws-sdk.version from 1.12.625 to 1.12.631 (#1687)
  - build(deps): bump aws-sdk.version from 1.12.625 to 1.12.631
  - Remove problematic Composite Handler Tests that used mockStatic
  - Revert "build(deps): bump netty.version from 4.1.101.Final to 4.1.104.Final"
  - build(deps): bump aws-sdk.version from 1.12.609 to 1.12.625 (#1667)
  - build(deps): bump aws-sdk.version from 1.12.609 to 1.12.625
  - build(deps): bump hbase.version from 2.5.6-hadoop3 to 2.5.7-hadoop3 (#1671)
  - build(deps): bump hbase.version from 2.5.6-hadoop3 to 2.5.7-hadoop3
  - build(deps): bump com.sap.cloud.db.jdbc:ngdbc from 2.19.11 to 2.19.16 (#1675)
  - build(deps): bump com.sap.cloud.db.jdbc:ngdbc from 2.19.11 to 2.19.16
  - build(deps): bump com.github.spotbugs:spotbugs-annotations from 4.8.2 to 4.8.3 (#1659)
  - build(deps): bump com.github.spotbugs:spotbugs-annotations
  - build(deps): bump com.microsoft.azure:msal4j from 1.14.0 to 1.14.2 (#1674)
  - build(deps): bump com.microsoft.azure:msal4j from 1.14.0 to 1.14.2
  - build(deps): bump org.apache.maven.plugins:maven-compiler-plugin from 3.11.0 to 3.12.1 (#1670)
  - build(deps): bump org.apache.maven.plugins:maven-compiler-plugin
  - build(deps-dev): bump nl.jqno.equalsverifier:equalsverifier from 3.15.4 to 3.15.5 (#1676)
  - build(deps-dev): bump nl.jqno.equalsverifier:equalsverifier
  - build(deps): bump netty.version from 4.1.101.Final to 4.1.104.Final (#1658)
  - build(deps): bump netty.version from 4.1.101.Final to 4.1.104.Final
  - build(deps): bump surefire.failsafe.version from 3.2.2 to 3.2.3 (#1660)
  - build(deps): bump surefire.failsafe.version from 3.2.2 to 3.2.3
  - build(deps): bump software.amazon.msk:aws-msk-iam-auth from 2.0.0 to 2.0.1 (#1652)
  - build(deps): bump software.amazon.msk:aws-msk-iam-auth
  - build(deps): bump com.sap.cloud.db.jdbc:ngdbc from 2.18.16 to 2.19.11 (#1653)
  - build(deps): bump com.sap.cloud.db.jdbc:ngdbc from 2.18.16 to 2.19.11
  - build(deps): bump org.postgresql:postgresql from 42.7.0 to 42.7.1 (#1650)
  - build(deps): bump org.postgresql:postgresql from 42.7.0 to 42.7.1
  - build(deps): bump com.google.cloud:google-cloud-resourcemanager from 1.32.0 to 1.33.0 (#1648)
  - build(deps): bump com.google.cloud:google-cloud-resourcemanager
  - build(deps): bump org.apache.kafka:kafka-clients from 3.6.0 to 3.6.1 (#1647)
  - build(deps): bump org.apache.kafka:kafka-clients from 3.6.0 to 3.6.1
  - build(deps): bump software.amazon.jsii:jsii-runtime from 1.92.0 to 1.93.0 (#1649)
  - build(deps): bump software.amazon.jsii:jsii-runtime
  - build(deps): bump net.snowflake:snowflake-jdbc from 3.14.3 to 3.14.4 (#1654)
  - build(deps): bump net.snowflake:snowflake-jdbc from 3.14.3 to 3.14.4
  - build(deps): bump com.google.cloud:google-cloud-bigquery from 2.34.2 to 2.35.0 (#1651)
  - build(deps): bump com.google.cloud:google-cloud-bigquery
  - build(deps): bump gremlinDriverVersion from 3.7.0 to 3.7.1 (#1643)
  - build(deps): bump gremlinDriverVersion from 3.7.0 to 3.7.1
  - build(deps): bump com.google.cloud:google-cloud-storage from 2.29.1 to 2.30.1 (#1646)
  - build(deps): bump com.google.cloud:google-cloud-storage
  - build(deps): bump net.java.dev.jna:jna-platform from 5.13.0 to 5.14.0 (#1645)
  - build(deps): bump net.java.dev.jna:jna-platform from 5.13.0 to 5.14.0
  - build(deps): bump aws-sdk.version from 1.12.604 to 1.12.609 (#1642)
  - build(deps): bump aws-sdk.version from 1.12.604 to 1.12.609
  - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client from 8.5.3 to 8.11.2 (#1644)
  - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client
  - Merge branch 'master' into dependabot/github_actions/actions/setup-java-4
  - build(deps): bump actions/setup-java from 3 to 4
AbdulR3hman added a commit that referenced this pull request Jan 23, 2024
@namratas-trianz @AbdulR3hman
snowflake package size issue fix (#1719)
3ab88a4 
Co-authored-by: AbdulRehman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbdulR3hman AbdulR3hman AbdulR3hman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namratas-trianz @AbdulR3hman