Query Passthrough with JDBC-Based Connectors Implementations #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chngpe
reviewed
Nov 29, 2023
athena-federation-sdk/src/main/java/com/amazonaws/athena/connector/lambda/domain/Split.java
Outdated
Show resolved
Hide resolved
burhan94
requested changes
Nov 30, 2023
athena-federation-sdk/src/main/java/com/amazonaws/athena/connector/lambda/domain/Split.java
Outdated
Show resolved
Hide resolved
...on-sdk/src/main/java/com/amazonaws/athena/connector/lambda/domain/predicate/Constraints.java
Outdated
Show resolved
Hide resolved
...ration-sdk/src/main/java/com/amazonaws/athena/connector/lambda/metadata/GetTableRequest.java
Outdated
Show resolved
Hide resolved
...ration-sdk/src/main/java/com/amazonaws/athena/connector/lambda/metadata/GetTableRequest.java
Outdated
Show resolved
Hide resolved
...ration-sdk/src/main/java/com/amazonaws/athena/connector/lambda/metadata/GetTableRequest.java
Outdated
Show resolved
Hide resolved
...ration-sdk/src/main/java/com/amazonaws/athena/connector/lambda/handlers/MetadataHandler.java
Show resolved
Hide resolved
...n-sdk/src/test/java/com/amazonaws/athena/connector/lambda/handlers/CompositeHandlerTest.java
Outdated
Show resolved
Hide resolved
...on-sdk/src/main/java/com/amazonaws/athena/connector/lambda/domain/predicate/Constraints.java
Outdated
Show resolved
Hide resolved
...ration-sdk/src/main/java/com/amazonaws/athena/connector/lambda/handlers/MetadataHandler.java
Outdated
Show resolved
Hide resolved
AbdulR3hman
changed the title
AbdulR3hman
changed the title
added 17 commits
February 2, 2024 19:03
…t; todo revert" This reverts commit 0d384e5.
…eck for the QPT map
…eck for the QPT map
…eck for the QPT map
AbdulR3hman
force-pushed
the
querypassthrough
branch
from
7735f27 to
7a19c9b
Compare
added 3 commits
February 2, 2024 21:22
AbdulR3hman
force-pushed
the
querypassthrough
branch
from
7a19c9b to
c3eb1aa
Compare
|
closing this; will re-open a targeted PRs that are modular and focused thus easier to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change will allow us to implement QPT (Query Pass-Through) for Athena Connectors. This is only a draft change to get early feedback on the SDK changes whilst making further improvement engine-side.
Beside the changes to enable qpt SDK-side, I've also implemented QPT for MySQL, PostgreSQL, Redshift Connectors as a reference implementation.
*** Please Don't merge just yet ***
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.