Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(client-s3): disable checksum calculation and validation in legacy tests #6804

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 15, 2025

Issue

Missed in #6750

Description

Disables checksum calculation and validation in legacy tests

Testing

Before

$ ./node_modules/.bin/cucumber-js --fail-fast -t "@s3"
This Node.js version (v22.11.0) has not been tested with this version of Cucumber; it should work normally, but please raise an issue if you see anything unexpected.
.........................................................................F--.-------------------------------------------------------------------------------------------------------------------------------------------------------

Failures:

1) Scenario: Operating on a bucket using path style # features/s3/buckets.feature:56
   ✔ Before # features/extra/hooks.js:15
   ✔ Before # features/s3/step_definitions/buckets.js:3
   ✔ Before # features/s3/step_definitions/hooks.js:3
   ✔ Before # features/s3/step_definitions/proxy.js:5
   ✔ Given I force path style requests # features/s3/step_definitions/buckets.js:235
   ✔ And I create a bucket # features/extra/hooks.js:38
   ✔ When I put "abc" to the key "hello" in the bucket # features/s3/step_definitions/buckets.js:254
   ✔ And I get the key "hello" in the bucket # features/s3/step_definitions/buckets.js:263
   ✖ Then the bucket name should be in the request path # features/s3/step_definitions/buckets.js:242
       TypeError: Cannot read properties of undefined (reading 'path')
           at Object.<anonymous> (/local/home/trivikr/workspace/aws-sdk-js-v3/features/s3/step_definitions/buckets.js:243:35)
   - And the bucket name should not be in the request host # features/s3/step_definitions/buckets.js:248
   - Then I delete the object "hello" from the bucket # features/s3/step_definitions/buckets.js:271
   ✔ After # features/s3/step_definitions/buckets.js:8

23 scenarios (1 failed, 15 skipped, 7 passed)
128 steps (1 failed, 93 skipped, 34 passed)
0m07.069s (executing steps: 0m06.990s)

After

$ ./node_modules/.bin/cucumber-js --fail-fast -t "@s3"
...
23 scenarios (23 passed)
128 steps (128 passed)
0m09.966s (executing steps: 0m09.409s)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner January 15, 2025 08:58
@kuhe kuhe merged commit ee6abd0 into aws:main Jan 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants