Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AWS::Lambda::Alias type resolving #7833

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rangerthegood
Copy link

Which issue(s) does this change fix?

#7832

Why is this change necessary?

Without this change it is not possible to use start-api when your SpecRestApi is wired up with a Lambda function Alias versus just a Lambda, which would work fine.

How does it address the issue?

The code change introduces a new type resolvers for AWS::Lambda:Alias, This resolver works by looking at the FunctionName property. Once it has access to the function name it uses the existing arn_resolver function to retrieve the result.

What side effects does this change have?

None, that I'm aware of, I've introduced an additional test case to demonstrate the feature, and the existing test cases all still pass.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rangerthegood rangerthegood requested a review from a team as a code owner January 12, 2025 15:39
@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant