Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable linting for new runtimes in the tests #474

Merged
merged 2 commits into from
Dec 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions tests/integration/build_invoke/java/test_java_21.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,69 +11,49 @@

class BuildInvoke_java21_cookiecutter_aws_sam_hello_java_gradle(BuildInvokeBase.HelloWorldWithLocationBuildInvokeBase):
directory = "java21/hello-gradle"
# TODO: remove the line remove once java 21 is GA
should_test_lint = False


class BuildInvoke_java21_cookiecutter_aws_sam_hello_java_maven(BuildInvokeBase.HelloWorldWithLocationBuildInvokeBase):
directory = "java21/hello-maven"
# TODO: remove the line remove once java 21 is GA
should_test_lint = False


class BuildInvoke_java21_cookiecutter_aws_sam_eventbridge_hello_java_gradle(
BuildInvokeBase.EventBridgeHelloWorldBuildInvokeBase
):
directory = "java21/event-bridge-gradle"
# TODO: remove the line remove once java 21 is GA
should_test_lint = False


class BuildInvoke_java21_cookiecutter_aws_sam_eventbridge_hello_java_maven(
BuildInvokeBase.EventBridgeHelloWorldBuildInvokeBase
):
directory = "java21/event-bridge-maven"
# TODO: remove the line remove once java 21 is GA
should_test_lint = False


@pytest.mark.skip("eventbridge schema app requires credential to pull missing files, skip")
class BuildInvoke_java21_cookiecutter_aws_sam_eventbridge_schema_app_java_gradle(BuildInvokeBase.BuildInvokeBase):
directory = "java21/event-bridge-schema-gradle"
# TODO: remove the line remove once java 21 is GA
should_test_lint = False


@pytest.mark.skip("eventbridge schema app requires credential to pull missing files, skip")
class BuildInvoke_java21_cookiecutter_aws_sam_eventbridge_schema_app_java_maven(BuildInvokeBase.BuildInvokeBase):
directory = "java21/event-bridge-schema-maven"
# TODO: remove the line remove once java 21 is GA
should_test_lint = False


class BuildInvoke_java21_cookiecutter_aws_sam_step_functions_sample_app_gradle(BuildInvokeBase.BuildInvokeBase):
directory = "java21/step-func-gradle"
# TODO: remove the line remove once java 21 is GA
should_test_lint = False


class BuildInvoke_java21_cookiecutter_aws_sam_step_functions_sample_app_maven(BuildInvokeBase.BuildInvokeBase):
directory = "java21/step-func-maven"
# TODO: remove the line remove once java 21 is GA
should_test_lint = False


class BuildInvoke_image_java21_cookiecutter_aws_sam_hello_java_gradle_lambda_image(
BuildInvokeBase.HelloWorldWithLocationBuildInvokeBase
):
directory = "java21/hello-img-gradle"
# TODO: remove the line remove once java 21 is GA
should_test_lint = False


class BuildInvoke_image_java21_cookiecutter_aws_sam_hello_java_maven_lambda_image(
BuildInvokeBase.HelloWorldWithLocationBuildInvokeBase
):
directory = "java21/hello-img-maven"
# TODO: remove the line remove once java 21 is GA
should_test_lint = False
22 changes: 0 additions & 22 deletions tests/integration/build_invoke/node/test_node_20.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,71 +9,49 @@

class BuildInvoke_nodejs20_x_cookiecutter_aws_sam_hello_nodejs(BuildInvokeBase.SimpleHelloWorldBuildInvokeBase):
directory = "nodejs20.x/hello"
# TODO (hawflau): remove after GA
should_test_lint = False

class BuildInvoke_nodejs20_x_cookiecutter_aws_sam_step_functions_sample_app(BuildInvokeBase.BuildInvokeBase):
directory = "nodejs20.x/step-func"
# TODO (hawflau): remove after GA
should_test_lint = False


class BuildInvoke_nodejs20_x_cookiecutter_quick_start_from_scratch(BuildInvokeBase.BuildInvokeBase):
directory = "nodejs20.x/scratch"
# TODO (hawflau): remove after GA
should_test_lint = False


class BuildInvoke_nodejs20_x_cookiecutter_quick_start_cloudwatch_events(BuildInvokeBase.BuildInvokeBase):
directory = "nodejs20.x/cw-event"
# TODO (hawflau): remove after GA
should_test_lint = False


class BuildInvoke_nodejs20_x_cookiecutter_quick_start_s3(BuildInvokeBase.BuildInvokeBase):
directory = "nodejs20.x/s3"
# TODO (hawflau): remove after GA
should_test_lint = False

# if we want to check response json, we need to setup bucket for testing


class BuildInvoke_nodejs20_x_cookiecutter_quick_start_sns(BuildInvokeBase.BuildInvokeBase):
directory = "nodejs20.x/sns"
# TODO (hawflau): remove after GA
should_test_lint = False


class BuildInvoke_nodejs20_x_cookiecutter_quick_start_sqs(BuildInvokeBase.BuildInvokeBase):
directory = "nodejs20.x/sqs"
# TODO (hawflau): remove after GA
should_test_lint = False


class BuildInvoke_nodejs20_x_cookiecutter_quick_start_response_streaming(BuildInvokeBase.BuildInvokeBase):
directory = "nodejs20.x/response-streaming"
# TODO (hawflau): remove after GA
should_test_lint = False


class BuildInvoke_nodejs20_x_cookiecutter_quick_start_web(BuildInvokeBase.QuickStartWebBuildInvokeBase):
directory = "nodejs20.x/web"
# TODO (hawflau): remove after GA
should_test_lint = False


class BuildInvoke_nodejs20_x_cookiecutter_quick_start_full_stack(BuildInvokeBase.QuickStartWebBuildInvokeBase):
directory = "nodejs20.x/full-stack"
# TODO (hawflau): remove after GA
should_test_lint = False


class BuildInvoke_image_nodejs20_x_cookiecutter_aws_sam_hello_nodejs_lambda_image(
BuildInvokeBase.SimpleHelloWorldBuildInvokeBase
):
directory = "nodejs20.x/hello-img"
# TODO (hawflau): remove after GA
should_test_lint = False


class BuildInvoke_nodejs20_x_cookiecutter_aws_sam_gql_quick_start(BuildInvokeBase.BuildInvokeBase):
Expand Down
13 changes: 0 additions & 13 deletions tests/integration/build_invoke/python/test_python_3_11.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,65 +10,52 @@

class BuildInvoke_python3_11_cookiecutter_aws_sam_hello_python(BuildInvokeBase.SimpleHelloWorldBuildInvokeBase):
directory = "python3.11/hello"
should_test_lint: bool = False


class BuildInvoke_python3_11_cookiecutter_aws_sam_eventBridge_python(
BuildInvokeBase.EventBridgeHelloWorldBuildInvokeBase
):
directory = "python3.11/event-bridge"
should_test_lint: bool = False

class BuildInvoke_python3_11_cookiecutter_aws_sam_quick_start_web_with_connectors(BuildInvokeBase.QuickStartWebBuildInvokeBase):
directory = "python3.11/web-conn"
should_test_lint: bool = False


class BuildInvoke_python3_11_cookiecutter_aws_sam_step_functions_with_connectors(BuildInvokeBase.BuildInvokeBase):
directory = "python3.11/step-func-conn"
should_test_lint: bool = False


@skip("eventbridge schema app requires credential to pull missing files, skip")
class BuildInvoke_python3_11_cookiecutter_aws_sam_eventbridge_schema_app_python(BuildInvokeBase.BuildInvokeBase):
directory = "python3.11/event-bridge-schema"
should_test_lint: bool = False


class BuildInvoke_python3_11_cookiecutter_aws_sam_step_functions_sample_app(BuildInvokeBase.BuildInvokeBase):
directory = "python3.11/step-func"
should_test_lint: bool = False


# if we want to check response json, we need to setup efs
class BuildInvoke_python3_11_cookiecutter_aws_sam_efs_python(BuildInvokeBase.BuildInvokeBase):
directory = "python3.11/efs"
should_test_lint: bool = False


class BuildInvoke_python3_11_cookiecutter_aws_sam_hello_pt_python(BuildInvokeBase.SimpleHelloWorldBuildInvokeBase):
directory = "python3.11/hello-pt"
should_test_lint: bool = False


class BuildInvoke_image_python3_11_cookiecutter_aws_sam_hello_python_lambda_image(
BuildInvokeBase.SimpleHelloWorldBuildInvokeBase
):
directory = "python3.11/hello-img"
should_test_lint: bool = False

class BuildInvoke_python3_11_pytorch(BuildInvokeBase.BuildInvokeBase):
directory = "python3.11/apigw-pytorch"
should_test_lint: bool = False

class BuildInvoke_python3_11_scikit(BuildInvokeBase.BuildInvokeBase):
directory = "python3.11/apigw-scikit"
should_test_lint: bool = False

class BuildInvoke_python3_11_tensorflow(BuildInvokeBase.BuildInvokeBase):
directory = "python3.11/apigw-tensorflow"
should_test_lint: bool = False

class BuildInvoke_python3_11_xgboost(BuildInvokeBase.BuildInvokeBase):
directory = "python3.11/apigw-xgboost"
should_test_lint: bool = False
14 changes: 1 addition & 13 deletions tests/integration/build_invoke/python/test_python_3_12.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,67 +10,55 @@

class BuildInvoke_python3_12_cookiecutter_aws_sam_hello_python(BuildInvokeBase.SimpleHelloWorldBuildInvokeBase):
directory = "python3.12/hello"
should_test_lint: bool = False


class BuildInvoke_python3_12_cookiecutter_aws_sam_eventBridge_python(
BuildInvokeBase.EventBridgeHelloWorldBuildInvokeBase
):
directory = "python3.12/event-bridge"
should_test_lint: bool = False


class BuildInvoke_python3_12_cookiecutter_aws_sam_quick_start_web_with_connectors(BuildInvokeBase.QuickStartWebBuildInvokeBase):
directory = "python3.12/web-conn"
should_test_lint: bool = False


class BuildInvoke_python3_12_cookiecutter_aws_sam_step_functions_with_connectors(BuildInvokeBase.BuildInvokeBase):
directory = "python3.12/step-func-conn"
should_test_lint: bool = False


@skip("eventbridge schema app requires credential to pull missing files, skip")
class BuildInvoke_python3_12_cookiecutter_aws_sam_eventbridge_schema_app_python(BuildInvokeBase.BuildInvokeBase):
directory = "python3.12/event-bridge-schema"
should_test_lint: bool = False


class BuildInvoke_python3_12_cookiecutter_aws_sam_step_functions_sample_app(BuildInvokeBase.BuildInvokeBase):
directory = "python3.12/step-func"
should_test_lint: bool = False


# if we want to check response json, we need to setup efs
class BuildInvoke_python3_12_cookiecutter_aws_sam_efs_python(BuildInvokeBase.BuildInvokeBase):
directory = "python3.12/efs"
should_test_lint: bool = False


class BuildInvoke_python3_12_cookiecutter_aws_sam_hello_pt_python(BuildInvokeBase.SimpleHelloWorldBuildInvokeBase):
directory = "python3.12/hello-pt"
should_test_lint: bool = False


class BuildInvoke_image_python3_12_cookiecutter_aws_sam_hello_python_lambda_image(
BuildInvokeBase.SimpleHelloWorldBuildInvokeBase
):
directory = "python3.12/hello-img"
should_test_lint: bool = False

# TODO: uncomment below and add the template back in manifest-v2.json once PyTorch supports Python3.12
# class BuildInvoke_python3_12_pytorch(BuildInvokeBase.BuildInvokeBase):
# directory = "python3.12/apigw-pytorch"
# should_test_lint: bool = False

class BuildInvoke_python3_12_scikit(BuildInvokeBase.BuildInvokeBase):
directory = "python3.12/apigw-scikit"
should_test_lint: bool = False

# TODO: uncomment below and add the template back in manifest-v2.json once Tensorflow supports Python3.12
# class BuildInvoke_python3_12_tensorflow(BuildInvokeBase.BuildInvokeBase):
# directory = "python3.12/apigw-tensorflow"
# should_test_lint: bool = False

class BuildInvoke_python3_12_xgboost(BuildInvokeBase.BuildInvokeBase):
directory = "python3.12/apigw-xgboost"
should_test_lint: bool = False
3 changes: 0 additions & 3 deletions tests/integration/build_invoke/test_build_invoke_go1_x.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ class BuildInvoke_providedal2023_go_cookiecutter_aws_sam_hello_golang(BuildInvok
use_container = False
directory = "al2023/go/hello"

# TODO (hawflau): remove after GA
should_test_lint = False

class BuildInvoke_go1_x_cookiecutter_aws_sam_eventbridge_hello_golang(BuildInvokeBase.BuildInvokeBase):
use_container = False
directory = "go1.x/event-bridge"
Expand Down
2 changes: 0 additions & 2 deletions tests/integration/build_invoke/test_build_invoke_rust.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ class BuildInvoke_providedal2023_rust_cookiecutter_aws_sam_hello(BuildInvokeBase
use_container = False
directory = "al2023/rust/hello"
beta_features = True
# TODO (hawflau): remove after GA
should_test_lint = False

class BuildInvoke_provided_rust_cookiecutter_aws_sam_hello_dynamodb(BuildInvokeBase.BuildInvokeBase):
use_container = False
Expand Down
4 changes: 0 additions & 4 deletions tests/integration/build_invoke/test_ruby_3_2.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,10 @@

class BuildInvoke_ruby3_2_cookiecutter_aws_sam_hello_ruby(BuildInvokeBase.HelloWorldExclamationBuildInvokeBase):
directory = "ruby3.2/hello"
# TODO: Remove this line when Ruby3.2 is GA.
should_test_lint = False


class BuildInvoke_ruby3_2_cookiecutter_aws_sam_step_functions_sample_app(BuildInvokeBase.BuildInvokeBase):
directory = "ruby3.2/step-func"
# TODO: Remove this line when Ruby3.2 is GA.
should_test_lint = False

class BuildInvoke_image_ruby3_2_cookiecutter_aws_sam_hello_ruby_lambda_image(
BuildInvokeBase.HelloWorldExclamationBuildInvokeBase
Expand Down
2 changes: 0 additions & 2 deletions tests/integration/unit_test/test_unit_test_go1_x.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ class UnitTest_provided_go_cookiecutter_aws_sam_hello_golang(UnitTestBase.GoUnit
class UnitTest_providedal2023_go_cookiecutter_aws_sam_hello_golang(UnitTestBase.GoUnitTestBase):
directory = "al2023/go/hello"
code_directories = ["hello-world"]
# TODO (hawflau): remove after GA
should_test_lint = False

class UnitTest_go1_x_cookiecutter_aws_sam_eventbridge_hello_golang(UnitTestBase.GoUnitTestBase):
directory = "go1.x/event-bridge"
Expand Down
20 changes: 0 additions & 20 deletions tests/integration/unit_test/test_unit_test_java21.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,57 +6,41 @@
class UnitTest_java21_cookiecutter_aws_sam_hello_java_gradle(UnitTestBase.JavaUnitTestGradleBase):
directory = "java21/hello-gradle"
code_directories = ["HelloWorldFunction"]
# TODO: remove the line remove once java 21 is GA
should_test_lint = False

class UnitTest_java21_cookiecutter_aws_sam_hello_img_java_gradle(UnitTestBase.JavaUnitTestGradleBase):
directory = "java21/hello-img-gradle"
code_directories = ["HelloWorldFunction"]
# TODO: remove the line remove once java 21 is GA
should_test_lint = False


class UnitTest_java21_cookiecutter_aws_sam_hello_img_java_maven(UnitTestBase.JavaUnitTestMavenBase):
directory = "java21/hello-img-maven"
code_directories = ["HelloWorldFunction"]
# TODO: remove the line remove once java 21 is GA
should_test_lint = False

class UnitTest_java21_cookiecutter_aws_sam_hello_java_maven(UnitTestBase.JavaUnitTestMavenBase):
directory = "java21/hello-maven"
code_directories = ["HelloWorldFunction"]
# TODO: remove the line remove once java 21 is GA
should_test_lint = False


class UnitTest_java21_cookiecutter_aws_sam_eventbridge_hello_java_gradle(UnitTestBase.JavaUnitTestGradleBase):
directory = "java21/event-bridge-gradle"
code_directories = ["HelloWorldFunction"]
# TODO: remove the line remove once java 21 is GA
should_test_lint = False


class UnitTest_java21_cookiecutter_aws_sam_eventbridge_hello_java_maven(UnitTestBase.JavaUnitTestMavenBase):
directory = "java21/event-bridge-maven"
code_directories = ["HelloWorldFunction"]
# TODO: remove the line remove once java 21 is GA
should_test_lint = False


@skip("eventbridge schema app requires credential to pull missing files, skip")
class UnitTest_java21_cookiecutter_aws_sam_eventbridge_schema_app_java_gradle(UnitTestBase.JavaUnitTestGradleBase):
directory = "java21/event-bridge-schema-gradle"
code_directories = ["HelloWorldFunction"]
# TODO: remove the line remove once java 21 is GA
should_test_lint = False


@skip("eventbridge schema app requires credential to pull missing files, skip")
class UnitTest_java21_cookiecutter_aws_sam_eventbridge_schema_app_java_maven(UnitTestBase.JavaUnitTestMavenBase):
directory = "java21/event-bridge-schema-maven"
code_directories = ["HelloWorldFunction"]
# TODO: remove the line remove once java 21 is GA
should_test_lint = False


class UnitTest_java21_cookiecutter_aws_sam_step_functions_sample_app_gradle(UnitTestBase.JavaUnitTestGradleBase):
Expand All @@ -66,8 +50,6 @@ class UnitTest_java21_cookiecutter_aws_sam_step_functions_sample_app_gradle(Unit
"functions/StockChecker",
"functions/StockSeller",
]
# TODO: remove the line remove once java 21 is GA
should_test_lint = False


class UnitTest_java21_cookiecutter_aws_sam_step_functions_sample_app_maven(UnitTestBase.JavaUnitTestMavenBase):
Expand All @@ -77,5 +59,3 @@ class UnitTest_java21_cookiecutter_aws_sam_step_functions_sample_app_maven(UnitT
"functions/StockChecker",
"functions/StockSeller",
]
# TODO: remove the line remove once java 17 is GA
should_test_lint = False
Loading