Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Provided.al2023 implementation (#139)"" #463

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Revert "Revert "Provided.al2023 implementation (#139)"" #463

merged 2 commits into from
Nov 8, 2023

Conversation

hawflau
Copy link
Contributor

@hawflau hawflau commented Nov 7, 2023

Reverts #456

@hawflau hawflau requested a review from a team as a code owner November 7, 2023 17:46
@hawflau hawflau requested review from bentvelj and hnnasit and removed request for a team November 7, 2023 17:46
mndeveci
mndeveci approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@mndeveci mndeveci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Should we disable linting for this runtime since CI checks are failing?

@hawflau hawflau merged commit c8e1655 into master Nov 8, 2023
41 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucashuy lucashuy lucashuy approved these changes

@mndeveci mndeveci mndeveci approved these changes

@bentvelj bentvelj Awaiting requested review from bentvelj bentvelj is a code owner automatically assigned from aws/serverless-application-experience-sbt

@hnnasit hnnasit Awaiting requested review from hnnasit hnnasit is a code owner automatically assigned from aws/serverless-application-experience-sbt

Assignees
No one assigned
Labels
pr/internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hawflau @mndeveci @lucashuy