-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow extensions to be disabled #135
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good! The only thing I would ask is if you can add information about this on the README. Probably at the end of "How to configure", a small section describing the existence of this environment variable and what it does.
Sure. |
Same set of tests are failing even without my changes. I even tried by not including the extension in the docker image and still the same tests failing confirming that failures already existed, probably flaky. We may need to adjust the expected values in the tests to account for the longer delays to make the tests more stable. We could consider conditionally checking for long delays only for arm64 arch keeping amd64 values unchanged. |
Issue
Docker for Mac on Apple Silicon MacBooks fail to run SAM containers containing Rust Lambda extensions. This is affecting services that offer SAM based features and customers are blocked. Not sure if the problem is in Docker or Lambda runtime.
cc @valerena
Issues:
Error
Description of changes
Introducing new env variable
AWS_LAMBDA_RIE_DISABLE_EXTENSIONS
to disable extensions. With this feature customers can get around the problem by setting this env var in SAM template.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.