Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix already reserved panic on concurrent invokes #133

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

OJFord
Copy link

@OJFord OJFord commented Sep 19, 2024

Issue #, if available: #97

Description of changes:

Fixes the error:

[INFO] (rapid) ReserveFailed: AlreadyReserved
panic: runtime error: invalid memory address or nil pointer dereference

when there are multiple concurrent invocations.

Essentially, make the entire Invoke() call acquire mutex, and then remove others to avoid deadlock. I am not sure this is an entirely appropriate solution, but it does seem to work for me.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant