fix: properly accumulate custom headers #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onno-vos-dev
approved these changes
Dec 5, 2024
|
I'll roll out a release in the morning when I'm at my desk 👍 Thank you! 🙏 |
|
Release of v1.0.4 is done @jhosteny 👍 |
|
@onno-vos-dev fantastic, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @onnovos. I'm so sorry, but my original fix to this was incorrect. To be honest, I am not sure how it worked? This should properly handle the custom headers now.
I didn't see anywhere in the tests where I could add this and make sure it is properly being generated, but maybe I am missing something?
There is no rush on this - I am using the fork for now.