This repository has been archived by the owner on Aug 29, 2019. It is now read-only.
Update library to be python3.6 compatible #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know pr #32 exists to convert the repo to python3 using the 2to3 utility. I converted this manually to allow it to remain backwards compatible with python2.6 and python2.7. Cheers. |
cknave
reviewed
Nov 20, 2017
| @@ -61,7 +66,9 @@ def request(self, method, url, data={}, response='body'): | |||
| raise APIException( | |||
| '{0}: {1}'.format(error_type, error_msg)) | |||
|
|
|||
| if response == 'body' and isinstance(content, str): | |||
| if isinstance(content, six.binary_type): | |||
There was a problem hiding this comment.
Thanks for the PR! Looks good aside from needing to pull in six as a requirement. Can you check this without it?
An example from http://python3porting.com/noconv.html#more-bytes-strings-and-unicode:
>>> from __future__ import unicode_literals
>>> import sys
>>> if sys.version_info < (3,):
... text_type = unicode
... binary_type = str
... else:
... text_type = str
... binary_type = bytes
>>> isinstance('U\xf1ic\xf6de', text_type)
True
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.