Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: picker not working in modal forms #354

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Fix: picker not working in modal forms #354

merged 1 commit into from
Nov 25, 2023

Conversation

awcodes
Copy link
Owner

@awcodes awcodes commented Nov 25, 2023

No description provided.

@awcodes awcodes merged commit baa0fbc into 3.x Nov 25, 2023
1 check passed
@chosten
Copy link

chosten commented Nov 28, 2023

There is now a blank space at the bottom of the page because of the inline-block class used by the Filament modal.
Not sure what's the best way to get rid of that.

@awcodes
Copy link
Owner Author

awcodes commented Nov 29, 2023

@chosten this has been fixed in the latest release. Thanks.

@chosten
Copy link

chosten commented Nov 29, 2023

There is another problem related to this PR.
If the CuratorPicker is conditionally displayed, with a reactive checkbox for example, once it is hidden there is a JS error in the console. Uncaught Snapshot missing on Livewire component with id: ucxxxxx
It's not possible to open the modal anymore after this.

@awcodes
Copy link
Owner Author

awcodes commented Dec 1, 2023

Ugh. Ok. Thanks, I'll see about a fix soon. It may require a potential breaking change though. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awcodes @chosten