Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update class-spectra.php #51

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

josephdsouza86
Copy link
Contributor

Replace Spectra block background image URLs with Cloudflare URLs

Replace Spectra background image URLs with Cloudflare URLs
@av3nger
Copy link
Owner

av3nger commented Oct 5, 2024

@josephdsouza86,
Could you please provide some steps to replicate and test this? I tried to add a Spectra container block and set the background image on the block. The proposed fix, unfortunately, did not fix the issue.

@josephdsouza86
Copy link
Contributor Author

josephdsouza86 commented Oct 5, 2024 via email

@av3nger av3nger changed the base branch from master to release/1.9.3 October 7, 2024 04:10
Copy link

sonarqubecloud bot commented Oct 7, 2024

@av3nger
Copy link
Owner

av3nger commented Oct 7, 2024

@josephdsouza86, good tip. Disabling the "File Generation" option did make this work. I've made some code adjustments to the PR to simplify and improve compatibility with the WordPress coding standards. Thanks for the PR.

@av3nger av3nger merged commit 25d2de3 into av3nger:release/1.9.3 Oct 7, 2024
2 checks passed
@josephdsouza86
Copy link
Contributor Author

josephdsouza86 commented Oct 7, 2024 via email

@josephdsouza86
Copy link
Contributor Author

Hey @av3nger, I've just taken a look at the file based CSS method and this seems to work for me. I don't know whether it's your refactoring that's solved this or whether clicking the "Regenerate Assets" button on your instance would have triggered the CSS to rebuild from a cached version and then include the CDN URLs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants