Plot while syncing #2487
Merged
Plot while syncing #2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParthDesai
approved these changes
Feb 1, 2024
| @@ -303,21 +305,36 @@ where | |||
|
|
|||
| info!("Synchronizing piece cache"); | |||
|
|
|||
| // TODO: Query from the DSN too such that we don't build outdated cache at start if node is | |||
There was a problem hiding this comment.
Is this TODO no longer apply here?
There was a problem hiding this comment.
Yes, we query it from the node instead now. I mean we could query DSN from farmer as well, but for simplicity of the implementation I decided to not do that
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
Plot while syncing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on changes introduced in #2476 and resolves #2400 by only waiting for node to become aware of archival history, not to sync to the tip.
This means that piece cache sync and plotting can happen in parallel to node sync and reduce total amount of time farmer needs before they can start farming.
While the logic here is not perfect, I believe it is good enough for things to work reasonably well in practice, better than they did before.
Code contributor checklist: