Remove auto staking on farmer rewards #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedhavyas
requested review from
nazar-pc,
rg3l3dr and
NingLin-P
as code owners
vedhavyas
force-pushed
the
remove_auto_staking
branch
from
726fd2f to
36f4a31
Compare
vedhavyas
changed the title
NingLin-P
previously approved these changes
Nov 7, 2023
NingLin-P
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove auto staking from pallet domains since this is confusing users per @jfrank-summit
We would need to revisit this auto staking feature with scaling in mind due to constraints from staking. I have bumped
transaction_versionof the runtime accordingly but did not bump thespec_versionsince this will done in a seperate PR when we make a runtime upgrade to Gemini-3gcc: @dariolina
Code contributor checklist: