-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signal finder #404
Open
pvh
wants to merge
59
commits into
main
Choose a base branch
from
signal-finder
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Signal finder #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resumably caused by my recent patch
…tion. this code needs serious rethinking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A signals-lite based implementation of the new approach to find(). I think this is now on a pretty promising path it:
The signals implementation is and is intended to be quite minimal but it probably needs a few more minor features. Eliminating manual deregistration would be one goal, and progressing in "epochs" to avoid glitches in the matrix would be the other. Cycle detection was a good idea. I may yet cave and adopt / vendor something small into the library but this isn't meant to be a broadly adopted signals library, just a small thing that we can adapt into the many other frameworks and libraries in the ecosystem.
Some notes: as of this writing there are still about a third of the repo tests failing. If this direction continues to work I'll probably move the find() logic into a standalone file so that it can be more easily inspected / tested. I'd also like to try updating DocHandle to emit one of these signals (at least optionally) as the document evolves.
I'd also like to reduce the duplication between dochandle and the find code in terms of state tracking as part of the cleanup but that might mean some adjustment of the current soon-to-be-deprecated sync protocol and I'm avoiding that can o' worms.